-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 1 tutorial #650
Chapter 1 tutorial #650
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the file to docs/tutorials/getting-started.mdx
@sandren any feedback? |
Thanks for working on this. It's ok that it's still a work-in-progress, but we shouldn't merge any placeholder content. I notice a few pieces:
It would be better to highlight what you can do in the client components section (instead of saying what you cannot do in server components). That will help balance those two sections as well. Also I understand the routing section is scoped to what's present in the default starter, but it should still cover dynamic rendering, segment routes, etc. Thanks! 🙂 |
@sandren That all sounds good!
Thanks for reviewing 🙏🏼 |
That's fine as long as the language of Chapter 1 doesn't imply that single-routes are all that are available. It should be clear that it's only covering those for now because that's what's present in the starter. 🙂 |
Awesome, I'll add something in that section about going over the rest of the routing in the next chapter! 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few small revisions, but otherwise everything looks good to me. Thanks @dizzyjaguar! 🙂
Yeah! |
#620